Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: options input type for more clarity #296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicbovee
Copy link

@nicbovee nicbovee commented Feb 28, 2023

Description

I created a standalone options type for the saveMindfulSession that should better satisfy the type requirements of the native code.

Fixes #295

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings

@nicbovee
Copy link
Author

nicbovee commented Mar 9, 2023

Hi @RuanAzevedo, your team may just be busy with other things at the moment, but I wanted to make sure there isn't anything I need to do with this to get it reviewed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

saveMindfulSession requires startDate and endDate but HealthValueOptions marks these properties to optional.
1 participant