Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voice-over crash #2

Draft
wants to merge 1 commit into
base: agendrix
Choose a base branch
from

Conversation

YannickGagnon
Copy link

J’ai faite quelques lecture hier à propos de l’accessibilité, c’est un monde fascinant.
Jai trouvé un work-around ce matin en troubleshoot le code de la lib qui appel notre delegate calendarCurrentPageDidChange il semblerait que le problème vienne de la méthode delegate - (void)scrollViewWillEndDragging:(UIScrollView *)scrollView withVelocity:(CGPoint)velocity targetContentOffset:(inout CGPoint *)targetContentOffset Lorsque que l’événement est lancé par un module tel que voiceover, le targetContentOffset est toujours un CGPoInt(0,0), Donc ceci selon mes observations patch le problème et explique pourquoi le calendar pick la date minimum 1970

@YannickGagnon YannickGagnon self-assigned this Jan 16, 2025
@YannickGagnon YannickGagnon marked this pull request as draft January 16, 2025 13:47
Copy link
Member

@Mathbl Mathbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça évite que ça crash, mais par contre il reste que quand on hover sur la flèche de droite et qu'on fait un voiceover "swipe", ça scroll le calendrier et on tombe en 2099.

C'est quand même mieux qu'un crash tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants