Skip to content

Commit

Permalink
Use ReviewDog for Shellcheck checks, not CircleCI (#93)
Browse files Browse the repository at this point in the history
* Add shellcheck to ReviewDog

See https://github.com/reviewdog/action-shellcheck

* Remove shellcheck on CircleCI

As we are now using it on ReviewDog instead
  • Loading branch information
johnboyes authored Apr 23, 2020
1 parent 21c8021 commit 7f3a932
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
version: 2.1

orbs:
shellcheck: circleci/[email protected]
docker: agilepathway/[email protected]

executors:
Expand All @@ -12,7 +11,6 @@ executors:
workflows:
build-and-publish-docker-image:
jobs:
- shellcheck/check
- go-test
- compile-mage-scripts
- docker/publish:
Expand Down
16 changes: 16 additions & 0 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,19 @@ jobs:
with:
github_token: ${{ secrets.github_token }}
reporter: github-check

name: reviewdog

shellcheck:
name: runner / shellcheck
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: shellcheck
uses: reviewdog/action-shellcheck@v1
with:
github_token: ${{ secrets.github_token }}
reporter: github-check
path: "."
pattern: "*.sh"
exclude: "./.git/*"

0 comments on commit 7f3a932

Please sign in to comment.