Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pause(): Fixed handling for same status and changed toggle logic #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pause(): Fixed handling for same status and changed toggle logic #3

wants to merge 1 commit into from

Conversation

RiZKiT
Copy link

@RiZKiT RiZKiT commented Apr 27, 2012

  • Fixed handling when p == this.paused. That broke the slideshow animation before, now it just returns, because nothing has to be changed
  • Changed toggle logic code, that was a bit too cryptic and mind bending before (this.paused was play and vice verca) and switched pause and play code block then.
  • Added true/false support info

- Improved handling when p == this.paused. That broke the slideshow a…
423ecdc 
…nimation before, now it just returns, because nothing has to be changed

- Improved toggle logic. That was a bit too cryptic and mind bending before (this.paused was play and vice verca)
- switched pause and play code block
- added true/false support info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RiZKiT