Add startupable #16
Add startupable #16
Conversation
|
Autofac support started, will continue netcore later |
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
==========================================
- Coverage 78.59% 78.51% -0.09%
==========================================
Files 19 19
Lines 710 712 +2
==========================================
+ Hits 558 559 +1
- Misses 152 153 +1
Continue to review full report at Codecov.
|
| @@ -25,6 +26,18 @@ public static class StartupExtension | |||
| return rtn; | |||
| } | |||
|
|
|||
| public static IServiceProvider UseAgodaIoCStartupable(this IServiceProvider app) | |||
| { | |||
| foreach (var startupable in app.GetServices<IStartupable>()) | |||
There was a problem hiding this comment.
Note: Not sure if GetServices returns null or an empty list.
| Somedata = 0; | ||
| } | ||
| public int Somedata { get; set; } | ||
| public void Start() |
There was a problem hiding this comment.
Ideally, it would be nice if the startup process could run asynchronously. I would expect that most of the implementation will communicate with other services etc. therefore it might be better to start returning a Task from the start.
| if (startupable == null) | ||
| throw new Exception( | ||
| "No service found that inherit from IStartupable but UseAgodaIoCStartupable was called"); | ||
| startupable.Start(); |
There was a problem hiding this comment.
maybe for a future iteration however it would be nice if you could specify the degree of parallelism.
For issue #15