Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/rparn/AG0042' into rparn/AG0042
Browse files Browse the repository at this point in the history
# Conflicts:
#	src/Agoda.Analyzers/AgodaCustom/CustomRulesResources.resx
  • Loading branch information
rannes committed Oct 17, 2024
2 parents 2e377a6 + 9057643 commit e8b7207
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Agoda.Analyzers/AgodaCustom/CustomRulesResources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ One exception is logging, where it can be useful to see the exact DC / cluster /
<value>You are using either an interpolated string or string concatenation in your logs, change these to the message template format to preserve structure in your logs</value>
</data>
<data name="AG0042Title" xml:space="preserve">
<value>QuerySelectorAsync makes things more flaky. Use locator-based "IPage.Locator" instead, as Playwright supports that better</value>
<value>QuerySelectorAsync usage found Replace with Locator or GetByRole for more reliable tests</value>
</data>
<data name="AG0043Title" xml:space="preserve">
<value>BuildServiceProvider detected in request processing code. This may cause memory leaks. Remove the BuildServiceProvider() call and let the framework manage the service provider lifecycle.</value>
Expand Down

0 comments on commit e8b7207

Please sign in to comment.