-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise rules and begin to add meta data #200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 75.21% 75.81% +0.60%
==========================================
Files 70 70
Lines 2606 2729 +123
Branches 317 317
==========================================
+ Hits 1960 2069 +109
- Misses 564 578 +14
Partials 82 82 ☔ View full report in Codecov by Sentry. |
rannes
approved these changes
Nov 18, 2024
src/Agoda.Analyzers/AgodaCustom/AG0020AvoidReturningNullEnumerablesFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Agoda.Analyzers/AgodaCustom/AG0022RemoveSyncMethodFixProvider.cs
Outdated
Show resolved
Hide resolved
going to merge in and revise the estimates for tech debt later |
joeldickson
changed the title
Revise rules and being to add meta data
Revise rules and begin to add meta data
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There 2 changes in this PR.
The second part is about me wanting to collect some more accurate data about how much tech debt is in a system, the reason i want to use the Analyzers for it is i want to be able to enforces as a part of linting creation people to think about how much work it is to fix the things they are flagging, because the person creating the rule will be the best one to make this call.
At the moment its just a simple "Time in minutes" we want to capture so that when we analyze a code base we can get a weighted estimate of how much technical debt for which problems are in there.
This is similar to the approach in software like Sonarqube