Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend build manual #11

Open
keszocze opened this issue Mar 13, 2015 · 6 comments
Open

Extend build manual #11

keszocze opened this issue Mar 13, 2015 · 6 comments

Comments

@keszocze
Copy link

The README.md should mention that the 'dependencies' folder needs to be manually pulled from github. If not, the error message is rather cryptic, not really giving a hint what has to be done.

ATM, the readme states 'The bootstrap.sh script provided by metaSMT can automatically download and install dependencies needed by metaSMT [...]' which is misleading as one has to download the dependencies manually (the git repo containing the dl information, that is).

@finnhaedicke
Copy link
Contributor

@keszocze: How do you like this version of the paragraph?

The bootstrap.sh script provided by metaSMT can automatically download the dependencies needed by metaSMT and setup a metaSMT build folder.
For the Git version of metaSMT you need to manually checkout the repository from https://github.com/agra-uni-bremen/dependencies.
You may require subversion and git to be installed.

@hriener
Copy link
Contributor

hriener commented Mar 15, 2015

@finnhaedicke: That sounds very good! Maybe it's also useful to add a statement to the error message produced by the ''bootstrap.sh'' script that refers to the README file.

@finnhaedicke
Copy link
Contributor

@hriener The error message currently is

if ! cd dependencies; then
  echo "missing dependencies folder. Please manually create a checkout or symlink in the metaSMT base folder."
  exit 2
fi

We could add
echo Please refer to the README.md for more details.

@hriener
Copy link
Contributor

hriener commented Mar 15, 2015

👍

echo ''missing "dependencies" directory. Please refer to the README.md for more details.''

@keszocze
Copy link
Author

I would suggest the following:

  1. To "0. Preparation" add the text (just a suggestion!):
    "metaSMT heavily relies on different dependencies (e.g. the different solving engines). For a succesfull build, a folder named 'dependencies' containing them is expetected to be present in the metaSMT main folder.
    You can either freshly clone the repository from https://github.com/agra-uni-bremen/dependencies.git
    or symlink to an existing dependencies folder. The foldername 'dependencies' is fixed and can not
    be changed"

Wich brings up the questions:

  • Why can't I change this folder name?
  • What happens if I use the option --deps dependencies/
  1. Add an option, --dl-dependencies or --clone-dependencies to the bootsrap.sh that performs
    the git clone command.

  2. Use the error messages proposed by hriener:
    echo ''missing "dependencies" directory. Please refer to the README.md for more details.''

@hriener
Copy link
Contributor

hriener commented Mar 15, 2015

I think @keszocze has some good points and his suggestion is very well thought.

Two more points:

  • It would be valuable if metaSMT could be build in a ''sane'' setting just by calling bootstraph.sh. Once people are addicted to the pure design and feature set offered, we can still point them to the README for learning about specialist configurations.
  • A lot of metaSMT bootstrap sessions fail in the first. It would be nice to have some advice in the README how to go on after an issue has been fixed (without building metaSMT again from scratch).

keszocze pushed a commit that referenced this issue Apr 7, 2015
This commit uses the text proposed by @keszocze in issue #11

Not that this does *not* close the issue as there are some open
questions left.
@keszocze keszocze mentioned this issue Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants