Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #17

Merged
merged 4 commits into from
Apr 9, 2015
Merged

Update readme #17

merged 4 commits into from
Apr 9, 2015

Conversation

keszocze
Copy link

@keszocze keszocze commented Apr 7, 2015

These commits address issues #11 and #16. Issue #16 will be closed while issue #11 still
has some open questions left.

Oliver Keszöcze added 2 commits April 7, 2015 17:28
Describes to ways of using metaSMT
* writing source code in the toolbox folder
* referencing metaSMT from an external project using cmake

Fixes #16
This commit uses the text proposed by @keszocze in issue #11

Not that this does *not* close the issue as there are some open
questions left.
@finnhaedicke
Copy link
Contributor

+1

@finnhaedicke
Copy link
Contributor

@hriener: are the typos fixed now?

@keszocze
Copy link
Author

keszocze commented Apr 9, 2015

Yes see commit f3e09e8

@finnhaedicke
Copy link
Contributor

I have seen It, I would like to hear hriener comment on it. From my side its good to go.
👍

@hriener
Copy link
Contributor

hriener commented Apr 9, 2015

I read it and like it 👍
@keszocze: Many thanks for improving the README so careful.
Minor comments: There is a dot missing at the end of the paragraph. ;)

Added missing dot at the end of paragraph
keszocze pushed a commit that referenced this pull request Apr 9, 2015
merge #17 
only additional change is the missing dot at the end of the paragraph as mentioned by @hreiner
@keszocze keszocze merged commit a1d1d1a into development Apr 9, 2015
@finnhaedicke finnhaedicke deleted the update_readme branch April 24, 2015 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants