Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon connection pooling #25

Merged
merged 9 commits into from
Jun 10, 2020
Merged

Carbon connection pooling #25

merged 9 commits into from
Jun 10, 2020

Conversation

zivillian
Copy link
Contributor

Add connectionpooling for carbon connection. Each pooled connection is tested before it is returned from pool. The PoolSize depends on the number of CPU, but does not limit the total number of concurrent connections. If the pool is exhausted, additional connections are created, but not stored in the pool after return.

@zivillian
Copy link
Contributor Author

inspired by #23

Copy link
Contributor

@wiredbarb wiredbarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the project's README.md to address this, including when (not) to call ClearPool() / ClearAllPools().

Graphite/GraphiteClient.cs Outdated Show resolved Hide resolved
Graphite/GraphiteClient.cs Outdated Show resolved Hide resolved
Graphite/CarbonConnectionPool.cs Outdated Show resolved Hide resolved
Graphite/CarbonConnectionPool.cs Outdated Show resolved Hide resolved
@zivillian zivillian merged commit ab4db53 into master Jun 10, 2020
@zivillian zivillian deleted the connection_pooling branch June 10, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants