Refactor Login to Support Manual Polling #307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @SuperLanceur ! Can you update the readme with this new way of handling login ? |
|
Done @ahivert ! The README now explains how to login in this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this as a library, it will allow a more flexible login process by separating the polling ID retrieval from the automatic polling. You can now call
request_polling_idto get the polling ID, wait for the user to click the link in the email, and then callcomplete_login_with_polling_idwith the polling ID to obtain the tokens. This change maintains backward compatibility by using these new methods within the existingloginmethod.Related to issue #306