Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not fail if missing permissions #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carlossg
Copy link

to some CRDs

Continue and display the tree with the objects that we can access

to some CRDs

Continue and display the tree with the objects that we can access
@ahmetb
Copy link
Owner

ahmetb commented Jun 22, 2022

This should be a user visible warning if anything (not a -v=2).

Ideally we still fail, but the error can say "use -ignore-errors to continue", and that's when it works like this. What do you think?

@carlossg
Copy link
Author

should it force the user to always use the flag (it can be too annoying) or just print a line for each item that could not be fetched?

@ahmetb
Copy link
Owner

ahmetb commented Jun 24, 2022

I think printing warning can be ok, but ideally at least there should be a way to still fail if that's what a user wants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants