Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual installation instructions for latest Go releases to README.md #395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sylvainfaivre
Copy link

The Manual Installation for macOS and Linux contained only the older bash scripts, so add instructions for the Go releases.

@ahmetb
Copy link
Owner

ahmetb commented Jul 20, 2023

It would be much better to provide replace old instructions with a wget/curl + chmod that downloads binaries, or just an explanation saying "go to Releases page, and put the binary somewhere in your PATH and chmod+x it".

Honestly not sure how many of the users aren't able to figure this out themselves though.

@sylvainfaivre
Copy link
Author

Well this MR's purpose was to give up to date instructions for the Go version.

When I installed this tool, I blindly followed the instructions from the README and installed the bash scripts.

Then a few months later, I wanted to see if there was an updated release, so I read the README again and was confused when I saw that I had in fact installed a much older release.

I feel that this MR fixes the instructions by providing an install procedure for the current version and making it clear that the bash scripts are the older version, and adding information about the completion scripts beeing needed in addition to the go binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants