Allow for user-defined libraries #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a mutator for LIBRARIES for cases where keyutil library names are not CentOS default.
houndci-bot
reviewed
Jan 12, 2017
|
|
||
| # Public: Update the shared library names, for systems with different | ||
| # libraries that CentOS installations. | ||
| # |
There was a problem hiding this comment.
Trailing whitespace detected.
houndci-bot
reviewed
Jan 12, 2017
| @@ -25,6 +25,14 @@ module KeyControl | |||
| def self.library_names | |||
| LIBRARIES | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
Trailing whitespace detected.
|
I'll be honest, I don't know how to submit a new patch which is why I haven't. |
|
The contributor guidelines assume you're going through a standard fork + branch workflow. I'm unsure how you'd update a submitted patch. Don't worry about dealing with the whitespace issues; I'll commit the fix with some minor adjustments over the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a mutator for
LIBRARIESfor cases wherekeyutillibrary names are not CentOS default.I needed this for two use cases:
jrubyit didn't seem to raise the same exception, but rather aLoadErrorwhich would terminate the process early.There is an edge case for systems that don't have it named in the same way as CentOS (which I couldn't find, although I didn't try too hard), if the calling application checks the ELF header of
keyctland identifies the correct library, it can then callkey_controlwith that library.