Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add me as a maintainer #43

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Add me as a maintainer #43

merged 1 commit into from
Jun 11, 2021

Conversation

Shreyanand
Copy link
Member

Related Issues and Dependencies

#31

This introduces a breaking change

  • Yes
  • No

Description

Adds me as a maintainer so that I can release patches.

@Shreyanand Shreyanand requested a review from tumido June 11, 2021 14:41
@Shreyanand Shreyanand requested a review from durandom as a code owner June 11, 2021 14:41
@sesheta sesheta requested a review from MichaelClifford June 11, 2021 14:41
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 11, 2021
aakankshaduggal
aakankshaduggal approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@aakankshaduggal aakankshaduggal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2021
@sesheta
Copy link
Contributor

sesheta commented Jun 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aakankshaduggal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2021
@sesheta sesheta merged commit 1499eed into master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakankshaduggal aakankshaduggal aakankshaduggal approved these changes

@tumido tumido Awaiting requested review from tumido tumido is a code owner

@durandom durandom Awaiting requested review from durandom durandom is a code owner

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford

Assignees

@aakankshaduggal aakankshaduggal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shreyanand @sesheta @aakankshaduggal