Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependencies #168

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: dependencies #168

wants to merge 7 commits into from

Conversation

lxsmnsyc
Copy link
Collaborator

@lxsmnsyc lxsmnsyc commented Dec 25, 2024

This fixes some weird dependencies react-scan has that shouldn't be there in the first place

Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-scan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 4:55am

Copy link

pkg-pr-new bot commented Dec 25, 2024

Open in Stackblitz

npm i https://pkg.pr.new/aidenybai/react-scan@168

commit: 5cb96e4

@@ -233,8 +229,11 @@
"@types/react": "^18.0.0",
"@types/react-reconciler": "^0.28.8",
"@types/react-router": "^5.1.0",
"@types/node": "^20.17.9",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this with pnpm add -Dw @types/node we need it in all workspaces.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well it doesn't have to be on all packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants