Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate from eslint to biome and improve architecture #186

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

refactor: migrate from eslint to biome and improve architecture #186

wants to merge 15 commits into from
+3,699 −2,475

Conversation

pivanov
Copy link
Collaborator

@pivanov pivanov commented Jan 9, 2025 •
edited
Loading

TODOS

@RobPruzan

  • port new outline logic over
  • implement settings

@pivanov

  • fix: the purple animated flash on state change, it spazzes out when things change frequently, that shouldn’t happen
  • fix: bug causing state updates to show every other change
  • fix: whats changed shouldn’t show if nothing changed
  • fix: overlay cursor should be always the default
  • fix: handle missing fiber when inspecting elements
  • fix: prevent inspecting the toolbar widget
  • fix: toolbar widget animations
  • fix: what changed metrics
  • fix: replay button behaviour
  • feat: remove audio stuff entirely in favore of settings
  • feat: add provider names to context area
  • feat: inspect timeline (@todo: @pivanov improve UI and finish the implementation)
  • cleanup old CSS stuff
  • Improve UX/UI/DX: Display props with the following visual cues:
    • 🛡️ Memoized props (safe and optimized).
    • 🔥 Non-memoized function props (potential performance issue).
    • 🔔 Props requiring observation (watch closely).
  • improve: overlay fade in/out instead of flick
  • improve: use bippy bippy 0.2.0
  • improve: remove react-reconciler package in favor of bippy
  • chore: replace ESLint with Biome for linting and formatting
  • chore: configure Biome with strict rules for:
    • Type checking and type safety
    • Code correctness (unused imports, variables, parameters)
    • Security (noExplicitAny, noConsole, dangerouslySetInnerHTML)
  • improve VSCode integration:
    • Set up Biome formatters for TS, JS, JSON, MD, CSS
    • Add automatic code actions and formatting
  • Improve React internals:
    • Remove react-reconciler dependency
    • Use bippy for Fiber/FiberRoot types
    • Use installRDTHook for React DevTools hook to avoid side effects

@RobPruzan & @pivanov

  • audit everything, make sure its 100% stable

@pivanov
refactor: migrate from eslint to biome and improve architecture
1649958 
- Replace ESLint with Biome for linting and formatting
- Configure Biome with strict rules for:
  - Type checking and type safety
  - Code correctness (unused imports, variables, parameters)
  - Security (noExplicitAny, noConsole, dangerouslySetInnerHTML)
- Improve VSCode integration:
  - Set up Biome formatters for TypeScript, JavaScript, and JSON
  - Configure Prettier for Markdown and HTML
  - Add automatic code actions and formatting
- Improve React internals:
  - Remove react-reconciler dependency
  - Use bippy for Fiber/FiberRoot types
  - Use installRDTHook for React DevTools hook to avoid side effects
- Update package dependencies and development tooling
- General improvements and code cleanup

BREAKING CHANGE: ESLint configuration removed in favor of Biome
@pivanov pivanov requested review from NisargIO and RobPruzan January 9, 2025 06:36
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025

@pivanov is attempting to deploy a commit to the Million Team on Vercel.

A member of the Team first needs to authorize it.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 9, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/aidenybai/react-scan@186

commit: ba19c7b

@pivanov pivanov requested a review from lxsmnsyc January 9, 2025 06:43
@pivanov pivanov requested a review from lxsmnsyc January 10, 2025 10:40
lxsmnsyc
lxsmnsyc reviewed Jan 10, 2025
View reviewed changes
biome.json Show resolved Hide resolved
lxsmnsyc
lxsmnsyc reviewed Jan 10, 2025
View reviewed changes
biome.json Show resolved Hide resolved
Repository owner deleted a comment from RobPruzan Jan 11, 2025
lxsmnsyc
lxsmnsyc approved these changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@lxsmnsyc lxsmnsyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pivanov pivanov force-pushed the refactor/migrate-to-biome branch from babf156 to 8ce3752 Compare January 12, 2025 01:05
@pivanov pivanov force-pushed the refactor/migrate-to-biome branch from 8ce3752 to 12d21a9 Compare January 12, 2025 02:09
@pivanov pivanov force-pushed the refactor/migrate-to-biome branch from ba55d08 to ba19c7b Compare January 14, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NisargIO NisargIO NisargIO left review comments

@lxsmnsyc lxsmnsyc lxsmnsyc approved these changes

@RobPruzan RobPruzan Awaiting requested review from RobPruzan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pivanov @lxsmnsyc @NisargIO