Lazy-docs #919
Open
Lazy-docs #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
==========================================
+ Coverage 68.26% 68.28% +0.01%
==========================================
Files 110 110
Lines 6211 6211
==========================================
+ Hits 4240 4241 +1
+ Misses 1971 1970 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
superstar54
requested changes
Nov 8, 2024
Comment on lines
+205
to
+206
| It is also used by the advanced panel to register the sub-sections of the advanced settings (e.g. magnetization, hubbard, etc.). | ||
|
|
There was a problem hiding this comment.
Could you explain a bit more?
Comment on lines
+89
to
+93
| # Controller methods | ||
| # EXAMPLE | ||
| def _on_trait_change(self, change): | ||
| # Update widgets based on model changes | ||
| ... |
There was a problem hiding this comment.
I think you also need to show how the widgets in the UI trigger the model update.
Comment on lines
+218
to
+221
| @tl.observe(tl.All) | ||
| def _on_any_change(self, change): | ||
| if change and change["name"] != "confirmed": | ||
| self._unconfirm() |
There was a problem hiding this comment.
Could you also explain _on_any_change? What is any?
There was a problem hiding this comment.
tl.All watches ALL traits. So ANY trait change triggers this, hence _on_any_change 🙂 Will make it more verbose in the docs 👍
edan-bainglass
force-pushed
the
lazy-loading
branch
3 times, most recently
from
578a997 to
a65beed
Compare
edan-bainglass
force-pushed
the
lazy-docs
branch
2 times, most recently
from
1a4741c to
55fe31a
Compare
edan-bainglass
force-pushed
the
lazy-docs
branch
from
55fe31a to
3689c7c
Compare
edan-bainglass
force-pushed
the
lazy-docs
branch
from
d8bde58 to
b8d3997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides documentation to accompany the changes made in the lazy-loading PR (#802)