-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: minor change on verdi plugin list
logic to show description
#6411
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -10,6 +10,7 @@ | |||||
|
||||||
import pytest | ||||||
from aiida.cmdline.commands import cmd_plugin | ||||||
from aiida.parsers import Parser | ||||||
from aiida.plugins import CalculationFactory, WorkflowFactory | ||||||
from aiida.plugins.entry_point import ENTRY_POINT_GROUP_TO_MODULE_PATH_MAP | ||||||
|
||||||
|
@@ -56,3 +57,20 @@ def test_plugin_list_detail(run_cli_command, entry_point_string): | |||||
|
||||||
result = run_cli_command(cmd_plugin.plugin_list, [entry_point_group, entry_point_name]) | ||||||
assert entry_point.__doc__ in result.output | ||||||
|
||||||
|
||||||
class CustomParser(Parser): | ||||||
@classmethod | ||||||
def get_description(cls) -> str: | ||||||
return 'str69' | ||||||
|
||||||
|
||||||
def test_plugin_description(run_cli_command, entry_points): | ||||||
"""Test if `verdi plugin list` would show description of an external plugin.""" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
from aiida.plugins import ParserFactory | ||||||
|
||||||
entry_points.add(CustomParser, 'aiida.parsers:custom.parser') | ||||||
assert ParserFactory('custom.parser') is CustomParser | ||||||
|
||||||
result = run_cli_command(cmd_plugin.plugin_list, ['aiida.parsers', 'custom.parser']) | ||||||
assert result.stdout_bytes.decode('utf-8').strip() == 'str69' | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This phrasing with a nested
if
feels a bit awkward. I think a more typical formulation would be