review applied

aiida_firecrest/scheduler.py

@@ -290,8 +290,7 @@ def get_jobs(
                     )
                 )
 
-            # TODO: The block below is commented, because the number of
-            # allocated cores is not returned by the FirecREST server
+            # See issue https://github.com/aiidateam/aiida-firecrest/issues/39
             # try:
             #     this_job.num_mpiprocs = int(thisjob_dict['number_cpus'])
             # except ValueError:
@@ -342,9 +341,8 @@ def get_jobs(
                         f"Couldn't parse time_used for job id {this_job.job_id}"
                     )
 
-            # TODO: The block below is commented, because dispatch_time
-            # is not returned explicitly by the FirecREST server
-            # in any case, the time tags doesn't seem to be used by AiiDA anyway.
+            # dispatch_time is not returned explicitly by the FirecREST server
+            # see: https://github.com/aiidateam/aiida-firecrest/issues/40
             #     try:
             #         this_job.dispatch_time = self._parse_time_string(thisjob_dict['dispatch_time'])
             #     except ValueError:

aiida_firecrest/transport.py

@@ -297,7 +297,7 @@ def __init__(
         :param url: URL to the FirecREST server
         :param token_uri: URI for retrieving FirecREST authentication tokens
         :param client_id: FirecREST client ID
-        :param client_secret: FirecREST client secret or Absolute path to an existing FirecREST Secret Key
+        :param client_secret: FirecREST client secret or str(Absolute path) to an existing FirecREST Secret Key
         :param client_machine: FirecREST machine secret
         :param small_file_size_mb: Maximum file size for direct transfer (MB)
         :param temp_directory: A temp directory on server for creating temporary files (compression, extraction, etc.)

pyproject.toml

@@ -28,7 +28,6 @@ dependencies = [
     "click",
     "pyfirecrest@git+https://github.com/khsrali/pyfirecrest.git@main#egg=pyfirecrest",
     "pyyaml",
-    "requests",
 ]
 
 [project.urls]