Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant deps pre-commit #44

Closed

Conversation

agoscinski
Copy link
Contributor

Having two places for dependencies create unnecessary redundancy. Better to have everything in the pyproject.toml0 and using this in the CI

I think pinning the python version in the pre-commit file is much of use, but more annoying than helpful, better would pinning package dependency versions.

@chrisjsewell
Copy link
Member

Yeh that's not how pre-commit works

@agoscinski
Copy link
Contributor Author

I am not so familiar with pre-commit, might be that I do something not ideal, but having the same version pinned at multiple locations is definitely not good.

@chrisjsewell
Copy link
Member

It creates sandboxed virtual environments, installing into the local environment won't do anything

There is no way to use config from the local repo: pre-commit/pre-commit#3243 (comment)

@agoscinski
Copy link
Contributor Author

Thanks for the info! I explored a bit some ideas to still remove the redundancy (extracting the version from file, using local repo), but it all seems going in a hacky route that might cause more maintenance problems than it helps, so I just let this go for now.

@agoscinski agoscinski closed this Jul 16, 2024
@agoscinski agoscinski deleted the remove-redundant-deps-pre-commit branch July 16, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants