HpParser: fix q-points/atoms output corner case #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current raw output parser would miss some corner cases, when lots of q-points are generated and the number has no more any space left from the parenthesis. The solution is to use a more general regex search. As a sanity check, also the perturbed atom number sites regex search is changed correspondingly.
|
@t-reents if you would be so kind to give it a quick look. It should be pretty straightforward. It's more or less a follow up of some previous changes you made as well somewhere else in the code. |
t-reents
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current raw output parser would miss some corner cases, when lots of q-points are generated and the number has no more any space left from the parenthesis.
The solution is to use a more general regex search. As a sanity check, also the perturbed atom number sites regex search is changed correspondingly.