Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add the XML schema for Quantum ESPRESSO v7.3.1 pw.x #1040

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Jul 24, 2024

No description provided.

@mbercx
Copy link
Member Author

mbercx commented Jul 24, 2024

@npaulish could you give this a spin for a small test system and send me the files? :))

@mbercx
Copy link
Member Author

mbercx commented Jul 24, 2024

@Minotakm I've added you to the repo as a collaborator. Once you accept, you can review this PR so you understand how to add support for new QE versions.

@mbercx mbercx requested a review from Minotakm July 25, 2024 09:21
Copy link
Collaborator

@Minotakm Minotakm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mbercx and @npaulish thanks for the changes 😄 . Is it possible to add the aiida.out and the data-file-schema.xml on the tests/parsers/fixtures/pw folder in a new folder called default_xml_<schema_date> ?

Minotakm
Minotakm previously approved these changes Jul 29, 2024
Copy link
Collaborator

@Minotakm Minotakm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that now everything is fine. Thanks @mbercx 😄

@mbercx
Copy link
Member Author

mbercx commented Jul 29, 2024

Almost, forgot to regenerate pytest regression file to latest (more compact) test files.

@mbercx mbercx marked this pull request as ready for review July 29, 2024 11:50
@mbercx mbercx requested a review from Minotakm July 29, 2024 11:55
@mbercx
Copy link
Member Author

mbercx commented Jul 29, 2024

Ok, fully ready for review now 👍

Copy link
Collaborator

@Minotakm Minotakm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that everything is alright. Thanks @mbercx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants