-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add the XML schema for Quantum ESPRESSO v7.3.1 pw.x
#1040
base: main
Are you sure you want to change the base?
Conversation
@npaulish could you give this a spin for a small test system and send me the files? :)) |
7c4fbb1
to
ec974d1
Compare
@Minotakm I've added you to the repo as a collaborator. Once you accept, you can review this PR so you understand how to add support for new QE versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7df8dda
to
6638a2f
Compare
6638a2f
to
e3c8c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that now everything is fine. Thanks @mbercx 😄
Almost, forgot to regenerate |
Ok, fully ready for review now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that everything is alright. Thanks @mbercx
No description provided.