Implement nodes/{node_id}/download endpoint
#74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoscinski
force-pushed
the
nodes-download-endpoint
branch
2 times, most recently
from
0d4202a to
1c71a6c
Compare
agoscinski
changed the title
nodes/{node_id}/download?{download_format} endpointnodes/{node_id}/download endpoint
agoscinski
force-pushed
the
nodes-download-endpoint
branch
from
1c71a6c to
6212b78
Compare
We implement the download of nodes that implement the export functionality as in aiida-core. We use StreamingResponse to send the data in byte chunks of size 1024. The tests require the client to be asynchronously to prevent I/O operations on closed file handlers. We require a numpy dependency because we need a node type that implemented the export functionality. The only node type that is not bounded to the domain of material science is ArrayData.
agoscinski
force-pushed
the
nodes-download-endpoint
branch
from
6212b78 to
9595cf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement the download of nodes that implement the export
functionality as in aiida-core. We use StreamingResponse to send the
data in byte chunks of size 1024.
The tests require the client to be asynchronously to prevent I/O
operations on closed file handlers.
We require a numpy dependency because we need a node type that
implemented the export functionality. The only node type that is not
bounded to the domain of material science is ArrayData.