Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developments - not fully integrated yet #16

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Sep 11, 2023

  1. Allow user to specify unique keys upon instantiation.
  2. Add order_by input which can be passed to the parent node query. Fixes ✨ NEW: Add order_by feature for FromGroupSubmissionController #13
  3. Verbose submission now has a formatted table.

Add the `unique_extra_keys` field to the `BaseSubmissionContoller`. This makes
it possible to set the keys that used to keep track of which processes are
already run upon instantiation of the controller, instead of having to write
a new class for each set of extras.
@mbercx mbercx marked this pull request as ready for review December 15, 2023 21:49
Add the `tmp.md` file, where small comments can be stored in Markdown format,
such as writing the commit messages of a set of commits in one PR.
When using the `BaseSubmissionController.submit_new_batch()` method with
`verbose == True`, print a table with an overview of completed, active, ...
runs.
Allow the user to order the submission via providing `order_by` during
instantiation. This field is directly passed to the `order_by` method of the
`QueryBuilder` used to get all extras which have to be run.
@mbercx mbercx merged commit 74c5e8a into aiidateam:main Dec 15, 2023
1 check passed
@mbercx mbercx deleted the tmp/dev branch December 15, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ NEW: Add order_by feature for FromGroupSubmissionController
1 participant