Implement issue #276 exclude certain URLs from checking, also impleme… #368
Conversation
…plement hosts to exclude
|
|
Thanks for your contribution, @elebeida. Could you please check the test coverage (cf. SonarQube report). I see some tests but mostly integration tests, but the exclusion logic should be covered by unit tests if possible. Additionally, it would be nice if you could also add some documentation wrt the new parameters (README of Gradle Plugin). |
| @@ -11,6 +11,9 @@ htmlSanityCheck { | |||
|
|
|||
| failOnErrors = true | |||
|
|
|||
| urlsToExclude = [ "https://www.aim42.org/"] | |||
| hostsToExclude = [ "www.aim42.org" ] | |||
|
|
|||
| logger.quiet "HSC version: ${htmlSanityCheckVersion}" | |||
There was a problem hiding this comment.
The purpose of the self check is to check the HSC documentation itself.
And it should not exclude essential links in the documentation.
Please drop this.
| <a href="http://included.com/page">Included Host</a> | ||
| </body> | ||
| </html> | ||
| """ |
There was a problem hiding this comment.
As far as I can see these HTMLs are only used in HtmlSanityCheckTaskFunctionalSpec (despite the other final statics that are used in both derived classes. If the code is only used in one derived class, move it there please.
|
Please rethink the approach, @elebeida towards a regular expression based implementation. Now that I look through your implementation and the original requirement of @rdmueller (who comes with a strong docToolchain back ground), I think that a regular expression is more general as it might cover URLs as well as Hosts. |
Implement issue #276 exclude certain URLs from checking, also implement hosts to exclude