Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyperopt.hp.randint #250

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Fix hyperopt.hp.randint #250

merged 4 commits into from
Dec 12, 2023

Conversation

MorrisNein
Copy link
Collaborator

Monkey-patch the hyperopt.hp.randint near the definition of HyperoptTuner.

Makes it return an int instead of a np.int64.

@MorrisNein MorrisNein changed the title Fix hyperopt randint Fix hyperopt.hp.randint Dec 9, 2023
@pep8speaks
Copy link

pep8speaks commented Dec 9, 2023

Hello @MorrisNein! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-12-12 14:41:08 UTC

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (085ca3d) 71.91% compared to head (45695fa) 71.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   71.91%   71.88%   -0.04%     
==========================================
  Files         136      136              
  Lines        8140     8145       +5     
==========================================
+ Hits         5854     5855       +1     
- Misses       2286     2290       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/unit/tuning/test_tuning.py Outdated Show resolved Hide resolved
golem/core/tuning/hyperopt_tuner.py Show resolved Hide resolved
@MorrisNein MorrisNein merged commit bcfad53 into main Dec 12, 2023
6 checks passed
@MorrisNein MorrisNein deleted the fix_hyperopt_randint branch December 12, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants