Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use list_objects_v2 in README #1259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nyoungstudios
Copy link

Description of Change

  • Updates README documentation to use list_objects_v2 instead of list_objects since that is what the AWS documentation recommends (and list_objects_v2 supports automatic pagination with the client.get_paginator function used in the sample). Should I add a comment or anything in the readme?
  • list_objects documentation recommends to use list_objects_v2 documentation

Assumptions

  • none

Checklist for All Submissions

  • I have added change info to CHANGES.rst
    • Do you want me to add something to the change list for a documentation change?
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant