Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10281/d54b3e27 backport][3.12] Update workflow to use upload-artifact v4 and download-artifact v4 #10289

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Jan 1, 2025

This is a backport of PR #10281 as merged into master (d54b3e2).

What do these changes do?

This updates the ci/cd workflow to use the upload-artifact v4 and download-artifact v4 github actions. The currently used upload-artifact and download-artifact will no longer work at the end of next month.
The changes are needed since v4 no longer has mutable artifacts, which was used to collect wheels from different architectures.

Fix #8588, Fix #8589, Fix #9009, Fix #10189, Fix #10191

Are there changes in behavior for the user?

No, the ci/cd workflow has been tested although without publishing.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

This updates the CI/CD workflow to use the `upload-artifact` v4 and
`download-artifact` v4 GitHub Actions. The currently used `upload-artifact`
and `download-artifact` will no longer work at the end of next month.
The changes are needed since v4 no longer has mutable artifacts, which
was used to collect wheels from different architectures.

Fixes #8588, fixes #8589, fixes #9009, fixes #10189, fixes #10191.

PR #10281.

(cherry picked from commit d54b3e2)
Copy link

codspeed-hq bot commented Jan 1, 2025

CodSpeed Performance Report

Merging #10289 will not alter performance

Comparing patchback/backports/3.12/d54b3e2712bb40644752f35787f701fef792f969/pr-10281 (d5e127b) with 3.12 (7fea191)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (7fea191) to head (d5e127b).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10289   +/-   ##
=======================================
  Coverage   98.08%   98.09%           
=======================================
  Files         123      123           
  Lines       37228    37228           
  Branches     2111     2111           
=======================================
+ Hits        36516    36519    +3     
+ Misses        543      540    -3     
  Partials      169      169           
Flag Coverage Δ
CI-GHA 97.98% <ø> (+<0.01%) ⬆️
OS-Linux 97.68% <ø> (+0.01%) ⬆️
OS-Windows 94.73% <ø> (ø)
OS-macOS 96.81% <ø> (ø)
Py-3.10.11 96.70% <ø> (+<0.01%) ⬆️
Py-3.10.15 97.27% <ø> (+<0.01%) ⬆️
Py-3.11.11 97.36% <ø> (-0.01%) ⬇️
Py-3.11.9 96.80% <ø> (ø)
Py-3.12.8 97.77% <ø> (ø)
Py-3.13.1 97.76% <ø> (ø)
Py-3.9.13 96.60% <ø> (-0.01%) ⬇️
Py-3.9.20 97.16% <ø> (ø)
Py-pypy7.3.16 96.75% <ø> (+<0.01%) ⬆️
VM-macos 96.81% <ø> (ø)
VM-ubuntu 97.68% <ø> (+0.01%) ⬆️
VM-windows 94.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webknjaz webknjaz merged commit d8f3853 into 3.12 Jan 1, 2025
36 checks passed
@webknjaz webknjaz deleted the patchback/backports/3.12/d54b3e2712bb40644752f35787f701fef792f969/pr-10281 branch January 1, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants