Skip to content

Commit

Permalink
Second round of pull request comments
Browse files Browse the repository at this point in the history
  • Loading branch information
AdrianAlcolea committed Nov 25, 2023
1 parent ca5c137 commit 4f17532
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 12 deletions.
9 changes: 1 addition & 8 deletions logstash/config/logstash.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1 @@
# This file has been generated by `generate_logstash_config_files.py`
# file, placed in `src/setup/logstash_setup`
# -------------------------------------------------------------------
http.host: "0.0.0.0"
xpack.monitoring.elasticsearch.hosts: [ "http://elasticsearch:9200" ]
xpack.monitoring.enabled: true
xpack.monitoring.elasticsearch.username: elastic
xpack.monitoring.elasticsearch.password: changeme

2 changes: 1 addition & 1 deletion src/setup/es_setup/generate_elasticsearch_indices.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def main():
es_client = ElasticsearchSingleton().client
global_fields = {"name", "plain", "html"}
entities = {
router.es_index: list(router.match_fields ^ global_fields) for router in router_list
router.es_index: list(router.indexed_fields ^ global_fields) for router in router_list
}
for es_index, fields in entities.items():
mapping = generate_mapping(fields)
Expand Down
6 changes: 3 additions & 3 deletions src/setup/logstash_setup/generate_logstash_config_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
pipeline_sql_path = BASE_PATH / "pipeline" / "sql"
DB_USER = "root"
DB_PASS = os.environ["MYSQL_ROOT_PASSWORD"]
ES_PASS = os.environ["ES_USER"]
ES_USER = os.environ["ES_PASSWORD"]
ES_USER = os.environ["ES_USER"]
ES_PASS = os.environ["ES_PASSWORD"]
GLOBAL_FIELDS = {"name", "plain", "html"}


Expand All @@ -45,7 +45,7 @@ def main():
for path in (CONFIG_PATH, PIPELINE_CONFIG_PATH, pipeline_sql_path):
path.mkdir(parents=True, exist_ok=True)
entities = {
router.es_index: list(router.match_fields ^ GLOBAL_FIELDS) for router in router_list
router.es_index: list(router.indexed_fields ^ GLOBAL_FIELDS) for router in router_list
}
render_parameters = {
"file": os.path.basename(__file__),
Expand Down

0 comments on commit 4f17532

Please sign in to comment.