Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update readme #174

Merged
merged 8 commits into from
Nov 8, 2023
Merged

Feature/update readme #174

merged 8 commits into from
Nov 8, 2023

Conversation

Taniya-Das
Copy link
Collaborator

remove outdated information

Copy link

@josvandervelde josvandervelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite a minimal change :)
Did you forget to commit some files?

I'd suggest removing more information, such "Starting a MySQL Server" (maybe keep a part to say how to connect to the db, mentioning ./scripts/database-connect.sql should be enough, I think), "#### Persistent Storage", "### Starting the REST API", "#### Using the Docker container". "#### Editing Files Locally".

Please also delete
"Please ask Jos van der Velde ([email protected]) for the keycloak secret, and to give your user the correct roles."

@Taniya-Das Taniya-Das added the documentation Improvements or additions to documentation label Nov 3, 2023
@Taniya-Das Taniya-Das marked this pull request as ready for review November 3, 2023 13:44
Copy link

@josvandervelde josvandervelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I saw that the Authentication part is not yet up to date, can you change that as well?
"Currently, the code is on default coupled with a keycloak running on test.openml.org." <-- by default we're using the local Keycloak now.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@josvandervelde josvandervelde merged commit 9a3834c into develop Nov 8, 2023
1 check passed
@josvandervelde josvandervelde deleted the feature/update_README branch November 8, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants