-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update readme #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite a minimal change :)
Did you forget to commit some files?
I'd suggest removing more information, such "Starting a MySQL Server" (maybe keep a part to say how to connect to the db, mentioning ./scripts/database-connect.sql
should be enough, I think), "#### Persistent Storage", "### Starting the REST API", "#### Using the Docker container". "#### Editing Files Locally".
Please also delete
"Please ask Jos van der Velde ([email protected]) for the keycloak secret, and to give your user the correct roles."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I saw that the Authentication part is not yet up to date, can you change that as well?
"Currently, the code is on default coupled with a keycloak running on test.openml.org." <-- by default we're using the local Keycloak now.
remove outdated information