Feature/get actual data from AI Assets #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the method to append endpoints for downloading the actual data On branch feature/get-actual-data Changes to be committed: new file: src/routers/resource_ai_asset_router.py modified: src/routers/resource_router.py modified: src/routers/resource_routers/dataset_router.py
On branch feature/get-actual-data Changes to be committed: modified: src/routers/resource_ai_asset_router.py modified: src/routers/resource_routers/case_study_router.py modified: src/routers/resource_routers/experiment_router.py modified: src/routers/resource_routers/ml_model_router.py modified: src/routers/resource_routers/publication_router.py new file: src/tests/routers/resource_routers/test_router_case_study_retrieve_data.py new file: src/tests/routers/resource_routers/test_router_dataset_retrieve_data.py new file: src/tests/routers/resource_routers/test_router_experiment_retrieve_data.py new file: src/tests/routers/resource_routers/test_router_ml_model_retrieve_data.py new file: src/tests/routers/resource_routers/test_router_publication_retrieve_data.py
src/tests/routers/resource_routers/test_router_case_study_retrieve_data.py
Outdated
Show resolved
Hide resolved
src/tests/routers/resource_routers/test_router_case_study_retrieve_data.py
Outdated
Show resolved
Hide resolved
src/tests/routers/resource_routers/test_router_case_study_retrieve_data.py
Outdated
Show resolved
Hide resolved
…distributions and improved the structure of the automated tests Changes to be committed: modified: src/routers/resource_ai_asset_router.py modified: src/routers/resource_router.py new file: src/tests/resources/contents/example1.csv new file: src/tests/resources/contents/example2.tsv new file: src/tests/routers/ai_asset_routers/__init__.py new file: src/tests/routers/ai_asset_routers/test_router_aiassets_retrieve_content.py deleted: src/tests/routers/resource_routers/test_router_case_study_retrieve_data.py deleted: src/tests/routers/resource_routers/test_router_dataset_retrieve_data.py deleted: src/tests/routers/resource_routers/test_router_experiment_retrieve_data.py deleted: src/tests/routers/resource_routers/test_router_ml_model_retrieve_data.py deleted: src/tests/routers/resource_routers/test_router_publication_retrieve_data.py
…appy_path_new_repository
| "Content-Disposition": ( | ||
| "attachment; " f"filename={filename or url.split('/')[-1]}" | ||
| ), | ||
| "Content-Type": f"{encoding_format or 'unknown'}", |
There was a problem hiding this comment.
"unknown" is not a valid mimetype.
https://stackoverflow.com/questions/1176022/unknown-file-type-mime suggests to remove the content-type in this case, that sounds like a good approach to me!
…n't be added to headers in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
ResourceAIAssetRouterwas created inheritingResourceRouter.The
createmethod in the new class adds two new routes to the APIRouter:1. f"{url_prefix}/{self.resource_name_plural}/{version}/{{identifier}}/data"
2. {url_prefix}/{self.resource_name_plural}/{version}/{{identifier}}/data/{{distribution_idx}}"
The
get_resource_data_funcreturns a function to get the actual data from an AI asset. Setting thedefaultparameter asFalse, it returns theget_resource_datafunction, which accepts the index of the distribution (i.e. 0, 1, 2, etc. for cases with multiple distribution). Ifdefaultis set toTrueit returns theget_resource_data_default, which always returns the first item of the distribution list (i.e. index 0).Finally, the AI assets: datasets, ml_models, experiments, and case_studies were modified to inherit
ResourceAIAssetRouter, instead of the previousResourceRouter.