Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenML connector for MLModels #202

Merged
merged 42 commits into from
Dec 22, 2023
Merged

Conversation

Taniya-Das
Copy link
Collaborator

@Taniya-Das Taniya-Das commented Nov 23, 2023

OpenML connector for fetching OpenML flows to AIoD ml models.
Note:

  1. All sklearn pipelines are ignored while fetching flows from OpenML. ToDo: discuss how to handle pipelines. Bonus: only fetch pipelines which have >= 1 run on OpenML.
  2. improve mlmodel.name (current implementation - openml.flow.name which might not be very clean).
  3. Discuss how to save flow parameters in Aiod.
  4. Discuss where to save language (human language) of flow (maybe ai_resource.metadata_language).

@Taniya-Das Taniya-Das marked this pull request as ready for review November 27, 2023 13:44
@Taniya-Das
Copy link
Collaborator Author

ToDo (after PR #204 approval):

  1. define "creator" as a dynamic class using resource_create.

Copy link

@josvandervelde josvandervelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, some comments. While running it, we got a weird KeyError: 'last_id' error, let's see if we can fix that as well.

src/connectors/openml/openml_mlmodel_connector.py Outdated Show resolved Hide resolved
src/connectors/openml/openml_mlmodel_connector.py Outdated Show resolved Hide resolved
src/connectors/openml/openml_mlmodel_connector.py Outdated Show resolved Hide resolved
connectors/openml/mlmodels.sh Show resolved Hide resolved
connectors/openml/cron Outdated Show resolved Hide resolved
connectors/openml/mlmodels.sh Outdated Show resolved Hide resolved
connectors/openml/entry.sh Outdated Show resolved Hide resolved
@Taniya-Das
Copy link
Collaborator Author

Taniya-Das commented Dec 21, 2023

To resolve 'last_id' error, handled cases when the item is ResourcewitrhRelations type or RecordError type.

Copy link

@josvandervelde josvandervelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, other than that I'd be happy to merge!

I don't think there is value already in this functionality (I don't think the user can use the current metadata), but it's fine for a start.
We might deploy this on the aiod-dev instance, and discuss integration with RAIL.

connectors/openml/mlmodels.sh Show resolved Hide resolved
src/connectors/openml/openml_mlmodel_connector.py Outdated Show resolved Hide resolved
Copy link

@josvandervelde josvandervelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

@Taniya-Das Taniya-Das merged commit 54b32c6 into develop Dec 22, 2023
1 check passed
@andrejridzik andrejridzik deleted the feature/openml_mlmodel_connector branch October 29, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants