Make serve() an async context manager
#515
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to get a clean shutdown of the asyncio-based QUIC server, we need to: - Make the `QuicServer.close()` method async. - Make the `serve()` method an async context manager.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 4999 5005 +6
=========================================
+ Hits 4999 5005 +6 ☔ View full report in Codecov by Sentry. |
|
@rthalley This is a breaking change, so it looks we would need to make the next release 2.0. |
|
I think clean closing is worth the breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get a clean shutdown of the asyncio-based QUIC server, we need to:
QuicServer.close()method async.serve()method an async context manager.See #513