Fix XCMP delivery issues #16
clippy
65 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 65 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.81.0 (eeb90cda1 2024-09-04)
- cargo 1.81.0 (2dbb1af80 2024-08-20)
- clippy 0.1.81 (eeb90cd 2024-09-04)
Annotations
Check warning on line 116 in node/src/cli.rs
github-actions / clippy
large size difference between variants
warning: large size difference between variants
--> node/src/cli.rs:73:1
|
73 | / pub enum Subcommand {
74 | | /// Key management cli utilities
75 | | #[clap(subcommand)]
76 | | Key(sc_cli::KeySubcommand),
| | -------------------------- the second-largest variant contains at least 264 bytes
... |
115 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd),
| | ----------------------------------------------- the largest variant contains at least 488 bytes
116 | | }
| |_^ the entire enum is at least 488 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
115 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 47 in node/src/chain_spec/mod.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> node/src/chain_spec/mod.rs:47:9
|
47 | return RobonomicsFamily::Mainnet;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
47 - return RobonomicsFamily::Mainnet;
47 + RobonomicsFamily::Mainnet
|
Check warning on line 825 in runtime/dev/src/lib.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> runtime/dev/src/lib.rs:825:13
|
825 | return (list, storage_info)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
825 | (list, storage_info)
|
Check warning on line 547 in runtime/dev/src/lib.rs
github-actions / clippy
this operation has no effect
warning: this operation has no effect
--> runtime/dev/src/lib.rs:547:37
|
547 | pub const MinimalBid: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
Check warning on line 395 in runtime/dev/src/lib.rs
github-actions / clippy
this operation has no effect
warning: this operation has no effect
--> runtime/dev/src/lib.rs:395:45
|
395 | pub const DataDepositPerByte: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
Check warning on line 377 in runtime/dev/src/lib.rs
github-actions / clippy
this operation has no effect
warning: this operation has no effect
--> runtime/dev/src/lib.rs:377:46
|
377 | pub const PreimageBaseDeposit: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
Check warning on line 245 in runtime/dev/src/lib.rs
github-actions / clippy
this operation has no effect
warning: this operation has no effect
--> runtime/dev/src/lib.rs:245:44
|
245 | pub const MinVestedTransfer: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
Check warning on line 191 in runtime/dev/src/lib.rs
github-actions / clippy
this operation has no effect
warning: this operation has no effect
--> runtime/dev/src/lib.rs:191:45
|
191 | pub const ExistentialDeposit: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
= note: `#[warn(clippy::identity_op)]` on by default
Check warning on line 340 in node/service/src/parachain.rs
github-actions / clippy
this function has too many arguments (9/7)
warning: this function has too many arguments (9/7)
--> node/service/src/parachain.rs:298:1
|
298 | #[sc_tracing::logging::prefix_logs_with("Parachain")]
| ^----------------------------------------------------
| |
| _in this procedural macro expansion
| |
299 | | pub async fn new_service<RuntimeApi, RB, BIQ, BIC>(
300 | | parachain_config: Configuration,
301 | | polkadot_config: Configuration,
... |
339 | | bool,
340 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>,
| |_______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: this warning originates in the attribute macro `sc_tracing::logging::prefix_logs_with` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 254 in node/service/src/parachain.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> node/service/src/parachain.rs:254:13
|
254 | &config,
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 210 in node/service/src/parachain.rs
github-actions / clippy
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/parachain.rs:196:6
|
196 | ) -> Result<
| ______^
197 | | PartialComponents<
198 | | ParachainClient<RuntimeApi>,
199 | | ParachainBackend,
... |
209 | | sc_service::Error,
210 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
Check warning on line 133 in node/service/src/parachain.rs
github-actions / clippy
this function has too many arguments (12/7)
warning: this function has too many arguments (12/7)
--> node/service/src/parachain.rs:120:1
|
120 | / pub fn build_open_consensus<RuntimeApi>(
121 | | para_id: ParaId,
122 | | lighthouse_account: AccountId,
123 | | client: Arc<ParachainClient<RuntimeApi>>,
... |
132 | | _force_authoring: bool,
133 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>
| |__________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
Check warning on line 114 in node/service/src/parachain.rs
github-actions / clippy
using `clone` on type `Option<&Registry>` which implements the `Copy` trait
warning: using `clone` on type `Option<&Registry>` which implements the `Copy` trait
--> node/service/src/parachain.rs:114:9
|
114 | registry.clone(),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `registry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
Check warning on line 235 in node/service/src/dev.rs
github-actions / clippy
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/dev.rs:227:6
|
227 | ) -> Result<
| ______^
228 | | (
229 | | TaskManager,
230 | | Arc<FullClient<Runtime>>,
... |
234 | | ServiceError,
235 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
Check warning on line 135 in node/service/src/dev.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> node/service/src/dev.rs:135:13
|
135 | &config,
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 102 in node/service/src/dev.rs
github-actions / clippy
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/dev.rs:84:6
|
84 | ) -> Result<
| ______^
85 | | sc_service::PartialComponents<
86 | | FullClient<Runtime>,
87 | | FullBackend,
... |
101 | | ServiceError,
102 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
Check warning on line 453 in frame/rws/src/lib.rs
github-actions / clippy
unused implementer of `frame_support::traits::Imbalance` that must be used
warning: unused implementer of `frame_support::traits::Imbalance` that must be used
--> frame/rws/src/lib.rs:453:21
|
453 | T::AuctionCurrency::burn(slash.peek());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_must_use)]` on by default
Check warning on line 404 in frame/rws/src/lib.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:404:26
|
404 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 376 in frame/rws/src/lib.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:376:26
|
376 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 357 in frame/rws/src/lib.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:357:26
|
357 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 335 in frame/rws/src/lib.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:335:26
|
335 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 292 in frame/rws/src/lib.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:292:26
|
292 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 405 in frame/rws/src/lib.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:405:16
|
405 | pub fn start_auction(
| ^^^^^^^^^^^^^ help: omit the `let` binding: `start_auction;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 377 in frame/rws/src/lib.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:377:16
|
377 | pub fn set_subscription(
| ^^^^^^^^^^^^^^^^ help: omit the `let` binding: `set_subscription;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 358 in frame/rws/src/lib.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:358:16
|
358 | pub fn set_oracle(
| ^^^^^^^^^^ help: omit the `let` binding: `set_oracle;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value