Only install PyHive for default HiveServer2Client driver #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
HiveServer2Client
defaults to using PyHive for its driver, it seems like we don't really need to installimpyla
andpyhive
. I think we should dropimpyla
from the default install reqs and raise if the user tries to use it for the Hive backend.I came across this recently when a few new employees installing Python on OSX via
brew install python
(which defaults to 3.7 now, problematic given all the packages lagging in support...) andomniduct[hive]
failed due tothriftpy
viaimpyla
. (Thriftpy/thriftpy#333)Impyla crashes on 3.7 on its own (cloudera/impyla#312) as well.
The 3.7 issue aside (PyHive is fixed: dropbox/PyHive#232), wdyt of installing only PyHive by default?