Update and simplify tox config file to ensure test coverage #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surprisingly, having the section [testenv:py39-linux-nodeellip] after
the more generic section
[testenv:py{39,311}-{linux,macos,win}-nodeellip] skip the more specific
section definition.
So the coverage was missed. This can be corrected by putting
[testenv:py39-linux-nodeellip] before [testenv:py{39,311}-{linux,macos,win}-nodeellip]
but this not intuitive.
We choose here to do everything in the main section [testenv] by making
full use of generative names and factor conditions.
In particular, to have a command be used if a given factor is absent, by
using an exclamation mark:
!nodeellip: ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly, having the section [testenv:py39-linux-nodeellip] after the more generic section
[testenv:py{39,311}-{linux,macos,win}-nodeellip] skip the more specific section definition.
So the coverage was missed. This can be corrected by putting [testenv:py39-linux-nodeellip] before [testenv:py{39,311}-{linux,macos,win}-nodeellip] but this not intuitive.
We choose here to do everything in the main section [testenv] by making full use of generative names and factor conditions.
In particular, to have a command be used if a given factor is absent, by using an exclamation mark: