Get rid of last tensorflow backend specificities #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To depend on keras 3.0 without enforcing a specific backend (tensorflow) we get rid of the last usage of tensorflow inside decomon library which is tf.linalg.solve. We create a dedicated operation which calls the proper function according to backend. For now, for other backend than tensorflow we raise a NotImplementedError. We update the test accordingly. And the get_lower_linear_hull_max() being bugged for now we xfail it.
To be fully agnostic, we prefer having utility functions that are checking the backend use like now `is_in_gpu_mode()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still had some code specific to tensorflow that we should make more agnostic now that we are using keras 3 which can work on several backends:
tensorflowimports in modules -> removed.numpy()->keras.ops.convert_to_numpy()-
tf.linalg.solve()-> create aLinalgSolvekeras operation which internally will check the backend to use proper code