fixes for default group command parsing and resolution of #8 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e output for a command, fix #8
…roke a couple tests. but we dont want to trim in some cases for pre-formatted examples, so it seems like the middle ground is only trim from the end of the string rather than both sides, tests pass ane examples are formatted correctly
…ed in certain cases
…application command, tests for examples & discussion stuff, test for default command
Whenever a command uses the -- option to separate options from arguments, the parser will stop parsing options and start parsing arguments instead. A test was added to prove its functionality.
…est. When parsing option token values in high arity options it would not stop parsing options if it found another option - it would parse it as option value. Now it is flexible in the number of option values, and it stops parsing option values if another valid option is found.
…o love from the IDE
….com/tesla/airline/commit/1e9d8ff2f55b0f017b93d1613d2265f9ba01bfa0) which provides support for custom creation of the commands instead of only using reflect to call the default constructor. this allows a hook in to provide an injector from guice that can be used to appropriate instantiate the commands
….com/tesla/airline/commit/9da1ef7bbbefe6ee1063b3b5f661cbb8f060c975) which alters the application of the command options post-creation with the new commandfactory hook
….com/tesla/airline/commit/72d9b2f1909f2939e7e59bd3ee70669830b3d324) which adds new annotations to add commands to groups without having to specify them in the cli builder
….com/tesla/airline/commit/267182c2e0358cc0f6a5d54a8568f90834b6bcb4) to pick up fix for groups processing
….com/tesla/airline/commit/db9d60ca4fc080d9d4810312804d71c99c0fcdcd) to pick up fix missing bindings when creating command metadata
….com/tesla/airline/commit/316967c4706039f36af2638e325d7087a8aed406) to pick up fix for guice compatibility in Help and usage corrections for hidden options
….com/tesla/airline/commit/316967c4706039f36af2638e325d7087a8aed406) to pick up fix for parsing of preexisting commands w/ metadata updates
….com/tesla/airline/commit/91101565a455a07268579cda8b9e115691aa7baa) to pick up further fixes for display of hidden options
…the builder. default is otherwise the default command factory, and you can still override the configured command factory with something from outside the cli * reflection hack to do the same reflect based metadata accessor magic for Guice Inject that is done for javax.inject.Inject
…order the commands are defined, both w/in a command in w/in the command hierarchy is respected. This way commands on super classes are shown after the commands on the sub classes which ensures the most relevant to the command options are shown first in the usage.
…c command, does not handle group usage printing * quick help hack to use the HTML format usage printing if a flag is enabled
This change adds the posibility to add multiple names for arguments, e.g. in a `git remote add` command the arguments can be `name` and `url`, therefore in the help message it's going to render `<name>` and `<url>` as separate arguments. A further improvement would be to handle tpyes and arity for arguments too.
…gic. The changes include: - showing which is the default command in a command group; - one can specify multiple separated names for command arguments; - replaced 'Whith no arguments' by 'By default' in command group message. Merge branch 'feature/helpText' into develop
…ting help page for a command group; Also changed the wording from 'the most commonly used' commands when it's actually showing all the commands
…pdated UsagePrinter to append a newline only when all brackets on that line have been closed.
…ptions and retweaked the overall display
Feature/better group output
…-formatted help output for making man pages
Feature/ronn output
Changed spaces to underscores in man page names because ronn requires on...
|
Closing this as the branch has acquired a bunch of unrelated commits. Please open a new pull request if this is still an issue. |
|
It's not a branch, it's a fork. One we've been maintaining while the 'main' repo has been dead. So yes, it's got 9 months of improvements to airline, one of which is a fix for #8. It also includes other pull requests that were never accepted into the mainline, which you can see in the history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.