Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme #10

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Fix readme #10

merged 3 commits into from
Jun 12, 2024

Conversation

davorrunje
Copy link
Collaborator

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

Copy link
Collaborator

@kumaranvpl kumaranvpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add similar weatherman to weather api change and description update in same PR

@kumaranvpl kumaranvpl added this pull request to the merge queue Jun 12, 2024
Merged via the queue into dev with commit 991969e Jun 12, 2024
18 checks passed
@kumaranvpl kumaranvpl deleted the fix-readme branch June 12, 2024 06:56
@kumaranvpl kumaranvpl mentioned this pull request Jun 12, 2024
13 tasks
github-merge-queue bot pushed a commit that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants