-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excluded indexes #132
Excluded indexes #132
Conversation
Renamed self.indexes to self.index (typo) Removed init=False from excluded indexes
Hi @aisk , a couple of questions: |
Thanks for the PR! Test and example will be appreciated. |
As Python's document said https://docs.python.org/3/library/exceptions.html#ValueError:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I only have some nitpicks:
Co-authored-by: AN Long <[email protected]>
Co-authored-by: AN Long <[email protected]>
Thanks for contributing! |
New PR to implement changes requested by @J3ldo and my suggestions discussed in PR #105 .
This PR also resolves Issue #29 .