Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded indexes #132

Merged
merged 26 commits into from
Jul 28, 2024
Merged

Excluded indexes #132

merged 26 commits into from
Jul 28, 2024

Conversation

iamalisalehi
Copy link
Contributor

New PR to implement changes requested by @J3ldo and my suggestions discussed in PR #105 .
This PR also resolves Issue #29 .

@iamalisalehi
Copy link
Contributor Author

Hi @aisk , a couple of questions:
Should I write a new test for excluded indexes? What about a new example?

src/pick/__init__.py Outdated Show resolved Hide resolved
@aisk
Copy link
Owner

aisk commented Jul 17, 2024

Hi @aisk , a couple of questions: Should I write a new test for excluded indexes? What about a new example?

Thanks for the PR! Test and example will be appreciated.

@iamalisalehi
Copy link
Contributor Author

Thanks for the comment @aisk , I think the PR is better now, but I'm not sure whether I raised the right error on line 59 or not.

@aisk
Copy link
Owner

aisk commented Jul 23, 2024

Thanks for the comment @aisk , I think the PR is better now, but I'm not sure whether I raised the right error on line 59 or not.

As Python's document said https://docs.python.org/3/library/exceptions.html#ValueError:

Raised when an operation or function receives an argument that has the right type but an inappropriate value, and the situation is not described by a more precise exception such as IndexError.

ValueError is the best choice in this case.

Copy link
Owner

@aisk aisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have some nitpicks:

example/disabled.py Show resolved Hide resolved
src/pick/__init__.py Outdated Show resolved Hide resolved
iamalisalehi and others added 2 commits July 24, 2024 23:17
@aisk
Copy link
Owner

aisk commented Jul 28, 2024

Thanks for contributing!

@aisk aisk merged commit 88ba0f3 into aisk:master Jul 28, 2024
15 checks passed
@iamalisalehi iamalisalehi deleted the excluded-indexes branch July 28, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants