Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add organization create command [EH-388] #341

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

watson28
Copy link
Contributor

add organization create command

New command for creating organizations. It receives the organization's name. The command asks for confirmation that the user understands what it means to create an Organization.

(all contributors please complete this section, including maintainers)

@watson28 watson28 requested a review from a team as a code owner June 22, 2023 15:17
@watson28 watson28 force-pushed the watson28-add-organzation-create branch from 5853e9a to 90a0095 Compare June 22, 2023 15:24
@rsalevsky rsalevsky requested a review from a team June 23, 2023 09:39
Copy link
Member

@ngilles-aiven ngilles-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a point about arg vs option for the name

aiven/client/cli.py Outdated Show resolved Hide resolved
@watson28 watson28 force-pushed the watson28-add-organzation-create branch from 90a0095 to 66e9eff Compare June 29, 2023 08:08
tests/test_argx.py Outdated Show resolved Hide resolved
@rominf
Copy link
Contributor

rominf commented Jun 30, 2023

Please rebase on main, I've merged the fix for pylint (#345).

@watson28 watson28 force-pushed the watson28-add-organzation-create branch from f78d927 to 0fc9faa Compare July 3, 2023 10:58
@ngilles-aiven ngilles-aiven merged commit d5e6337 into main Jul 3, 2023
@ngilles-aiven ngilles-aiven deleted the watson28-add-organzation-create branch July 3, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants