Use Guards to Ensure That Only One Request Creates or Deletes an App #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schrieveslaach
force-pushed
the
bugfix/deletion-guards
branch
from
12d1b37
to
2feadb7
Compare
schrieveslaach
changed the title
x1B
approved these changes
Apr 17, 2020
This commit ensures that subsequent DELETE requests of the same app name wait for the results of the first DELETE request. This makes the DELETE idempotent. Additionally, it ensures that POST and DELETE requests use the same guard based on the app name.
schrieveslaach
force-pushed
the
bugfix/deletion-guards
branch
from
2feadb7
to
b00c0b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that subsequent DELETE requests of the same app ID wait for the results of the first DELETE request. This makes the DELETE idempotent.