Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings the integration throw UI #4

Closed
wants to merge 112 commits into from
Closed

Conversation

Delmael
Copy link

@Delmael Delmael commented Jan 9, 2025

Hi
I've worked on this home assistant integration to mainly add the configuration by the UI.
I do not have a smartbox but a native HJM wifi heater which is working by the same plateform.

Changelog

  • Settings the integration throw UI

    • Adding main field for config entry (the username is the unique id)
    • Session options has an Options Flow
    • Reauthentication flow
    • Error handling
  • Improvement

If it fit your need I have other ideas 😃

Thanks,

@Delmael Delmael marked this pull request as ready for review January 9, 2025 17:18
@Delmael
Copy link
Author

Delmael commented Jan 14, 2025

Hi @ajtudela
Could you take a look on this 😃
Thanks,

@ajtudela
Copy link
Owner

Sorry, I'm not sure why I didn't received a notification.

Sure, I'll test it this evening.

@ajtudela
Copy link
Owner

I saw your fork didn't came from me. So there is a lot of changes in this PR.

Could you fork from me and make a new PR only with your changes?

Thanks!

@Delmael Delmael closed this by deleting the head repository Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants