Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for Georgian(ka) language #216

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

n1md7
Copy link

@n1md7 n1md7 commented Jul 21, 2021

Added Georgian language translations.

Since the official language code is ka I registered the key under that value. (https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes)

Copy link
Member

@epoberezkin epoberezkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Added some comments/questions

@@ -133,6 +138,7 @@ module.exports = {
id: "{{#def.n}} tidak boleh memiliki lebih dari {{=n}} item",
it: "{{#def.n}}non dovrebbe avere più di {{=n}} element{{#def.mPlural}}",
ja: "{{#def.n}}は{{=n}}以上あってはいけない",
ka: "{{#def.n}}არ უნდა შეიცავდეს {{=n}}-ზე მეტ ველ{{#def.mPlural}}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this error seems to be using the same word for items "ველ" as the next error uses for properties - should they be different?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and several errors below refer to array elements (JSON Schema spec calls them "items")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no exact match for those two words in Georgian both property and item could be referred as ველი. However, I researched a bit and it seems like among developers ველი is used as property and item as ელემენტი. So I modified it accordingly.

@@ -338,6 +351,7 @@ module.exports = {
id: "{{#def.n}} tidak boleh memiliki lebih dari {{=n}} item",
it: "{{#def.n}}non deve avere più di {{=n}} element{{#def.mPlural}}",
ja: "{{#def.n}}は{{=n}}個以上であってはいけない",
ka: "{{#def.n}}არ უნდა შეიცავდეს {{=n}}-ზე მეტ ველ{{#def.mPlural}}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@@ -362,6 +376,7 @@ module.exports = {
id: "{{#def.n}} tidak boleh kurang dari {{=n}} item",
it: "{{#def.n}}non deve avere meno di {{=n}} element{{#def.mPlural}}",
ja: "{{#def.n}}は{{=n}}個以下であってはいけない",
ka: "{{#def.n}}არ უნდა შეიცავდეს {{=n}}-ზე ნაკლებ ველ{{#def.mPlural}}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@@ -482,6 +501,7 @@ module.exports = {
id: "harus merupakan kelipatan dari {{=e.params.multipleOf}}",
it: "deve essere un multiplo di {{=e.params.multipleOf}}",
ja: "{{=e.params.multipleOf}}の倍数でなければいけない",
ka: "უნდა შეიცავდეს რამდენიმე {{=e.params.multipleOf}}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

google translate returns "Must contain several" - are you sure this is correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified

@@ -637,6 +663,7 @@ module.exports = {
en: "{{#def.n}}must NOT have more than {{=n}} item{{#def.mPlural}}",
de: "{{#def.n}}darf nicht mehr als {{=n}} Element{{#def.mPlural}} haben",
it: "{{#def.n}}non deve avere più di {{=n}} elementi{{#def.mPlural}}",
ka: "{{#def.n}}არ უნდა შეიცავდეს {{=n}}-ზე მეტ ველ{{#def.mPlural}}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@@ -701,6 +730,7 @@ module.exports = {
fr: 'la propriété doit correspondre au format "{{=e.params.missingPattern}}"',
id: 'harus memiliki pola pencocokan properti "{{=e.params.missingPattern}}"',
it: 'deve avere un attributo che corrisponda al formato "{{=e.params.missingPattern}}"',
ka: 'ველი უნდა შეესაბამებოდეს შაბლონს "{{=e.params.missingPattern}}"',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation: "The field must match the template". The error should be that "the field that matches the pattern is required"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -745,6 +776,7 @@ module.exports = {
fr: "doit contenir un élément valide",
id: "harus berisi item yang valid",
it: "deve contentere un elemento valido",
ka: "უნდა შეიცავდეს ვალიდურ ველს",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@n1md7
Copy link
Author

n1md7 commented Jan 31, 2022

@epoberezkin Can you tell me why tests are failing?

@n1md7 n1md7 requested a review from epoberezkin February 1, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants