Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travel Destination Cards #100

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Travel Destination Cards #100

merged 8 commits into from
Oct 15, 2024

Conversation

Artemiskgg1
Copy link
Contributor

@Artemiskgg1 Artemiskgg1 commented Oct 14, 2024

Added travel destination Card. Resolved all the conflicts.
The JSON file now contains 100 entries.
This PR closes #99

Copy link
Owner

@akanshSirohi akanshSirohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Artemiskgg1 Please add your card to README.md.

@akanshSirohi
Copy link
Owner

@Artemiskgg1 Also you don't need to close the PR to make changes, you can just continue with your changes in the same PR.

@Artemiskgg1
Copy link
Contributor Author

@Artemiskgg1 Also you don't need to close the PR to make changes, you can just continue with your changes in the same PR.

okay Will do it right now!

@Artemiskgg1
Copy link
Contributor Author

Artemiskgg1 commented Oct 15, 2024

@akanshSirohi Added the card to README.MD

@akanshSirohi akanshSirohi merged commit 1d617f7 into akanshSirohi:master Oct 15, 2024
3 checks passed
@akanshSirohi
Copy link
Owner

@Artemiskgg1 Your branch merged, you can checkout themes too in the project for contribution. Happy Coding :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travel Destination Card
2 participants