Remove unsupported operations

akash-akya · May 3, 2021 · 0b1f62b · 0b1f62b
1 parent 9bbda2f
commit 0b1f62b
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 12 deletions.
diff --git a/lib/vix/vips/blob.ex b/lib/vix/vips/blob.ex
@@ -1,7 +1,5 @@
 defmodule Vix.Vips.Blob do
-  @moduledoc """
-  *NOT supported yet*
-  """
+  @moduledoc false
 
   alias Vix.Type
 

diff --git a/lib/vix/vips/image.ex b/lib/vix/vips/image.ex
@@ -91,6 +91,8 @@ defmodule Vix.Vips.Image do
   @doc """
   Returns `vips_image` as binary based on the format specified by `suffix`. This function is similar to `write_to_file` but instead of writing the output to the file, it returns it as a binary.
 
+  Currently only TIFF, JPEG and PNG formats are supported.
+
   Save options may be encoded in the filename or given as a hash. For example:
 
   ```elixir

diff --git a/lib/vix/vips/operation.ex b/lib/vix/vips/operation.ex
@@ -76,9 +76,12 @@ defmodule Vix.Vips.OperationHelper do
   def reject_unsupported_operations(op_name) do
     {_desc, args} = vips_operation_arguments(op_name)
 
-    # we do not support mutable operations yet
-    Enum.any?(args, fn %{flags: flags} ->
-      :vips_argument_modify in flags
+    Enum.any?(args, fn %{flags: flags, value_type: value_type} ->
+      # we do not support mutable operations yet. Skip operations which use un-supported types as arguments
+      :vips_argument_modify in flags ||
+        value_type == "VipsSource" ||
+        value_type == "VipsTarget" ||
+        value_type == "VipsBlob"
     end)
   end
 

diff --git a/lib/vix/vips/source.ex b/lib/vix/vips/source.ex
@@ -1,7 +1,5 @@
 defmodule Vix.Vips.Source do
-  @moduledoc """
-  *NOT supported yet*
-  """
+  @moduledoc false
 
   alias Vix.Type
 

diff --git a/lib/vix/vips/target.ex b/lib/vix/vips/target.ex
@@ -1,7 +1,5 @@
 defmodule Vix.Vips.Target do
-  @moduledoc """
-  *NOT supported yet*
-  """
+  @moduledoc false
 
   alias Vix.Type