Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: node client discovery #99

Merged
merged 1 commit into from
Jan 9, 2024
Merged

feat: node client discovery #99

merged 1 commit into from
Jan 9, 2024

Conversation

troian
Copy link
Member

@troian troian commented Dec 16, 2023

@troian troian requested a review from a team as a code owner December 16, 2023 01:13
@troian troian changed the title feat: node client discovery [WIP] feat: node client discovery Dec 16, 2023
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (8db1f59) 3.45% compared to head (47a8c18) 3.45%.

Files Patch % Lines
go/util/ctxlog/ctxlog.go 0.00% 36 Missing ⚠️
go/manifest/v2beta2/group.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #99   +/-   ##
=====================================
  Coverage   3.45%   3.45%           
=====================================
  Files        293     294    +1     
  Lines      96776   96819   +43     
=====================================
+ Hits        3342    3346    +4     
- Misses     93269   93308   +39     
  Partials     165     165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@troian troian closed this Jan 7, 2024
@troian troian reopened this Jan 8, 2024
@troian troian changed the title [WIP] feat: node client discovery feat: node client discovery Jan 8, 2024
@troian troian merged commit e08955a into main Jan 9, 2024
6 of 7 checks passed
@troian troian deleted the client-discovery branch January 9, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant