New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/handle storage class validation #134

Merged

Redm4x merged 2 commits into main from features/handle-storage-class-validation

Mar 27, 2024

Contributor

Redm4x commented Mar 21, 2024

Update akashjs and remove temporary patch
Call akashjs validation method and show errors as CustomValidationError

Redm4x added 2 commits

March 21, 2024 10:51


          Update akashjs & remove patch

1c873bb


          Call akashjs validation and show error message as CustomValidation

c4f6c5d

baktun14 reviewed

View reviewed changes

deploy-web/src/utils/deploymentData/helpers.ts

@@ @@ -57,12 +57,12 @@ export function parseSizeStr(str: string) { @@
               type NetworkType = "beta2" | "beta3";
-              function isString(value: unknown): value is string {
-                return typeof value === "object" && value !== null && value.constructor === String;
+              function isValidString(value: unknown): value is string {

Contributor

baktun14 Mar 21, 2024

We could replace with lodash isString

Redm4x merged commit b07c1a7 into main

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet