feature: Enable Deployment from Git Repositories to Akash Network #358

HoomanDgtl · 2024-09-07T17:07:22Z

This is a PR that addresses the new feature addition, enabling deployment directly from GitHub, GitLab, or Bitbucket onto the Akash Network.

Issue: #226

fix: remove "Environment Variables" in expanded state (Remote Deploy)

baktun14 · 2024-09-11T17:23:46Z

apps/deploy-web/src/components/deployments/DeploymentDetail.tsx

-export function DeploymentDetail({ dseq }: React.PropsWithChildren<{ dseq: string }>) {
+export function DeploymentDetail() {
+  const dseq = (useParams()?.dseq as string) ?? "";
+  console.log(dseq);


baktun14 · 2024-09-11T17:26:55Z

apps/deploy-web/src/components/deployments/DeploymentDetail.tsx

@@ -28,7 +31,10 @@ import { DeploymentSubHeader } from "./DeploymentSubHeader";
 import { LeaseRow } from "./LeaseRow";
 import { ManifestUpdate } from "./ManifestUpdate";

-export function DeploymentDetail({ dseq }: React.PropsWithChildren<{ dseq: string }>) {
+export function DeploymentDetail() {


What's the reason of removing the props and using the useParams hook?

baktun14 · 2024-09-11T17:27:40Z

apps/deploy-web/src/components/deployments/DeploymentDetail.tsx

+  const [remoteDeploy, setRemoteDeploy] = useState<boolean>(false);
+  const [repo, setRepo] = useState<string | null>(null);
+  const [editedManifest, setEditedManifest] = useState<string | null>(null);
+  const [deploymentVersion, setDeploymentVersion] = useState<string | null>(null);
+  const [showOutsideDeploymentMessage, setShowOutsideDeploymentMessage] = useState(false);


Please move all these variables at the top of the components with over variables.

baktun14 · 2024-09-11T17:27:59Z

apps/deploy-web/src/components/deployments/DeploymentDetail.tsx

+  useEffect(() => {
+    const init = async () => {
+      const localDeploymentData = getDeploymentLocalData(deployment?.dseq || "");
+      console.log("localDeploymentData", !!localDeploymentData && !!localDeploymentData?.manifest);


baktun14 · 2024-09-11T17:28:04Z

apps/deploy-web/src/components/deployments/DeploymentDetail.tsx

+
+        setDeploymentVersion(version);
+      } else {
+        console.log("klsj");


baktun14 · 2024-09-11T20:23:42Z

apps/deploy-web/src/components/remote-deploy/update/Rollback.tsx

+};
+export default Rollback;
+
+const Field = ({ data, control }: { data: any; control: Control<SdlBuilderFormValuesType> }) => {


Extract this into a separate file.

baktun14 · 2024-09-11T20:23:54Z

apps/deploy-web/src/components/remote-deploy/update/Rollback.tsx

+                    value={value}
+                    onChange={e => {
+                      setValue(e.target.value);
+                      //   setFilteredData(data.filter((item: any) => item.name.toLowerCase().includes(e.target.value.toLowerCase())));


baktun14 · 2024-09-11T20:24:38Z

apps/deploy-web/src/components/remote-deploy/utils.ts

@@ -0,0 +1,79 @@
+import { Control } from "react-hook-form";


Move this under the /utils folder

baktun14 · 2024-09-11T20:27:21Z

apps/deploy-web/src/pages/deployments/[dseq]/index.tsx

-    }
-  };
-}
+// export async function getServerSideProps({ params }) {


Why remove that?

This was done to deploy the frontend on a third-party vendor. This was causing issues with build. This won't be removed, will revert it to previous state.

baktun14 · 2024-09-11T20:28:28Z

apps/deploy-web/src/utils/templates.ts

+  description: "Get started with a simple linux Ubuntu server!",
+  githubUrl: "",
+  valuesToChange: [],
+  content: `---


Maybe we could put this template in the awesome akash repo, so when you need to update it we don't need to release a new version of the console.

Done, now we are fetching this from awesome akash repo.

So we can remove it from here?

Refactor: Implement structural changes and add TypeScript types for better code clarity and type safety

ygrishajev · 2024-09-13T10:05:07Z

apps/deploy-web/src/components/deployments/DeploymentDetail.tsx

  const { address, isWalletLoaded } = useWallet();
  const { isSettingsInit } = useSettings();
  const [leaseRefs, setLeaseRefs] = useState<Array<any>>([]);
  const [deploymentManifest, setDeploymentManifest] = useState<string | null>(null);
+  const remoteDeploy: boolean = editedManifest && isRedeployImage(editedManifest) ? true : false;


Suggested change

const remoteDeploy: boolean = editedManifest && isRedeployImage(editedManifest) ? true : false;

const remoteDeploy: boolean = !!editedManifest && isRedeployImage(editedManifest);

ygrishajev · 2024-09-13T10:12:19Z

apps/deploy-web/src/components/deployments/DeploymentDetail.tsx

+    const init = async () => {
+      const localDeploymentData = getDeploymentLocalData(deployment?.dseq || "");
+
+      if (localDeploymentData && localDeploymentData.manifest) {


Suggested change

if (localDeploymentData && localDeploymentData.manifest) {

if (localDeploymentData?.manifest) {

ygrishajev · 2024-09-13T10:23:40Z

apps/deploy-web/src/components/deployments/ManifestUpdate.tsx

+  showOutsideDeploymentMessage: boolean;
+  editedManifest: string;
+  deploymentVersion: string | null;
+  setDeploymentVersion: (value: React.SetStateAction<string | null>) => void;


There's a type from react for such functions

Suggested change

setDeploymentVersion: (value: React.SetStateAction<string | null>) => void;

setDeploymentVersion: Dispatch<SetStateAction<string | null>>;

ygrishajev · 2024-09-13T10:39:37Z

apps/deploy-web/src/components/remote-deploy/EnvList.tsx

+  setIsEditingEnv: Dispatch<SetStateAction<boolean | number>>;
+};
+
+export const EnvVarList: React.FunctionComponent<Props> = ({ currentService, setIsEditingEnv, serviceIndex }) => {


have you checked this https://github.com/akash-network/console/blob/main/apps/deploy-web/src/utils/sdl/transformCustomSdlFields.ts? We used this to mutate sdl eventually

ygrishajev · 2024-09-13T10:42:18Z

apps/deploy-web/src/components/remote-deploy/GithubDeploy.tsx

+  );
+
+  useEffect(() => {
+    setOpen(true);


why not make it true by default then?

ygrishajev · 2024-09-13T10:48:37Z

apps/deploy-web/src/hooks/useWhenNot.ts

@@ -0,0 +1,12 @@
+import { useEffect } from "react";
+
+export function useWhenNot<T>(condition: T, run: () => void, deps: unknown[] = [], ifNot: () => void): void {


this is inherently misleading. It's read as run this function if condition is false. The last argument just raises questions and you gotta check implementation.

generally you can use multiple calls to useWhen

const condition: boolean useWhen(condition, cb) useWhen(!condition, cb)

ygrishajev · 2024-09-13T10:49:14Z

apps/deploy-web/src/components/remote-deploy/api/api.ts

@@ -0,0 +1,171 @@
+import { useMutation, useQuery } from "react-query";


ygrishajev · 2024-09-13T10:50:36Z

apps/deploy-web/src/pages/api/bitbucket/authenticate.ts

@@ -0,0 +1,30 @@
+import axios from "axios";
+
+export default function handler(req, res) {


what does this handle? can we get a descriptive names for this and other ones?

ygrishajev · 2024-09-13T10:52:31Z

apps/deploy-web/src/store/remoteDeployStore.ts

+
+import { OAuth } from "@src/components/remote-deploy/utils";
+
+const tokens = atomWithStorage<{


Suggested change

const tokens = atomWithStorage<{

export const tokens = atomWithStorage<{

no need to export object below

ygrishajev · 2024-09-13T10:53:55Z

apps/deploy-web/src/pages/api/bitbucket/authenticate.ts

+  if (code) {
+    axios
+      .post(tokenUrl, params.toString(), { headers })
+      .then(response => {


why not async/await?

ygrishajev · 2024-09-13T10:54:53Z

apps/deploy-web/src/pages/api/bitbucket/authenticate.ts

@@ -0,0 +1,30 @@
+import axios from "axios";


I'd say business logic should be abstracted from the handlers into dedicated modules. Would be better if those are classes.

fix : services for remote api and types

Pull changes

fix: fetch deploy.yml from awesome akash

baktun14 · 2024-09-20T14:50:59Z

Can you add the env vars you added to the config files? https://github.com/akash-network/console/blob/main/apps/deploy-web/src/config/browser-env.config.ts

…ackage-lock.json

envs

dharamveergit added 30 commits August 16, 2024 18:29

create 23 files and update 8 files

001311a

feat: Update Remote Deploy

93053db

update 4 files and create 2 files

774ed43

feat: new Repo selection

2c8636d

feat: Bitbucket Repo Selection

1dec0b3

feat: Gitlab Repo Selection

ab30a3b

fix: Gitlab repos ui fix

d7ef049

feat: update disable _pull

82e25fe

fix : update ui

89f5d5c

feat: New Frameworks

5c125d5

feat: vite Framework

6466920

fix: open fix repos

dc35ad4

update Repos.tsx, RemoteDeployUpdate.tsx and utils.ts

040a626

fix : more git repo fetch

d047872

test: temp fix

4fb2650

fix: relogin

0a8a3eb

feat: remote-deploy: bug fixes

cf05236

fix: redeploy advanced

a788457

update GihubDeploy.tsx

6805c5a

update 5 files

f681b75

update RemoteDeployUpdate.tsx and templates.ts

cf15e95

Merge remote-tracking branch 'upstream/main'

4ec0ee1

update : descriptions

449c4e4

fixes: type

29591f1

fix:repo filtering

5e5b392

remove: console.logs

7cd8536

fix: repo redeploy selection

21973f8

feat: images for git accounts

933c1a4

Merge remote-tracking branch 'upstream/main'

41a30c6

fix: filtering of repo (In Github)

b9239ea

dharamveergit added 2 commits September 9, 2024 17:17

fix: remove "Environment Variables" in expanded state (Remote Deploy)

1469353

Merge pull request #8 from dharamveergit/main

01708cd

fix: remove "Environment Variables" in expanded state (Remote Deploy)

anilmurty requested review from baktun14, ygrishajev and Redm4x September 9, 2024 16:13

baktun14 requested changes Sep 11, 2024

View reviewed changes

dharamveergit added 9 commits September 12, 2024 12:56

Merge remote-tracking branch 'upstream/main'

b9ed85b

fix: Reordering of variables and useEffects

29c8d5a

fix: code clean (Remote Deploy)

2da9923

fix: type fixes (Remote Deploy)

a693d7a

fix: types (Remote Deploy)

6f38fa9

update Repos.tsx, bitbucket-api.ts and gitlab-api.ts

299fe33

fix: vercel deploy fix

c026375

revert: vercel deploy

5647200

Merge pull request #9 from dharamveergit/main

bcf6b8d

Refactor: Implement structural changes and add TypeScript types for better code clarity and type safety

ygrishajev reviewed Sep 13, 2024

View reviewed changes

dharamveergit added 9 commits September 13, 2024 20:39

fix: types and api class logic (Remote Deployment)

5821792

fix: vercel deploy

1a2ab6b

Merge pull request #10 from dharamveergit/main

c133100

fix : services for remote api and types

Merge remote-tracking branch 'upstream/main'

999660c

Merge pull request #11 from dharamveergit/main

beebec7

Pull changes

fix: fetch deploy.yml from awesome akash

dfb4367

Merge pull request #12 from dharamveergit/main

166016f

fix: fetch deploy.yml from awesome akash

Merge remote-tracking branch 'upstream/main'

83a2a06

Merge remote-tracking branch 'upstream/main'

3052eca

dharamveergit added 2 commits September 20, 2024 23:47

build(deps): update browser-env.config.ts, env-config.schema.ts and p…

368b22a

…ackage-lock.json

Merge pull request #13 from dharamveergit/main

cc5beed

envs

HoomanDgtl closed this Sep 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: Enable Deployment from Git Repositories to Akash Network #358

feature: Enable Deployment from Git Repositories to Akash Network #358

HoomanDgtl commented Sep 7, 2024

baktun14 Sep 11, 2024

baktun14 Sep 11, 2024

baktun14 Sep 11, 2024

baktun14 Sep 11, 2024

baktun14 Sep 11, 2024

baktun14 Sep 11, 2024

baktun14 Sep 11, 2024

baktun14 Sep 11, 2024

baktun14 Sep 11, 2024

Chaitanyarai899 Sep 12, 2024

baktun14 Sep 11, 2024

Chaitanyarai899 Sep 16, 2024

baktun14 Sep 20, 2024

ygrishajev Sep 13, 2024

ygrishajev Sep 13, 2024

ygrishajev Sep 13, 2024

ygrishajev Sep 13, 2024

ygrishajev Sep 13, 2024

ygrishajev Sep 13, 2024

ygrishajev Sep 13, 2024

ygrishajev Sep 13, 2024

ygrishajev Sep 13, 2024

ygrishajev Sep 13, 2024

ygrishajev Sep 13, 2024

ygrishajev Sep 13, 2024

baktun14 commented Sep 20, 2024

	const remoteDeploy: boolean = editedManifest && isRedeployImage(editedManifest) ? true : false;
	const remoteDeploy: boolean = !!editedManifest && isRedeployImage(editedManifest);

	if (localDeploymentData && localDeploymentData.manifest) {
	if (localDeploymentData?.manifest) {

	setDeploymentVersion: (value: React.SetStateAction<string \| null>) => void;
	setDeploymentVersion: Dispatch<SetStateAction<string \| null>>;

		@@ -0,0 +1,12 @@
		import { useEffect } from "react";

		export function useWhenNot<T>(condition: T, run: () => void, deps: unknown[] = [], ifNot: () => void): void {

		@@ -0,0 +1,171 @@
		import { useMutation, useQuery } from "react-query";

		@@ -0,0 +1,30 @@
		import axios from "axios";

		export default function handler(req, res) {


		import { OAuth } from "@src/components/remote-deploy/utils";

		const tokens = atomWithStorage<{

	const tokens = atomWithStorage<{
	export const tokens = atomWithStorage<{

feature: Enable Deployment from Git Repositories to Akash Network #358

feature: Enable Deployment from Git Repositories to Akash Network #358

Conversation

HoomanDgtl commented Sep 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

baktun14 commented Sep 20, 2024